[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681558

Stanislav Ochotnicky <sochotni at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sochotni at redhat.com

--- Comment #1 from Stanislav Ochotnicky <sochotni at redhat.com> 2011-03-02 11:25:45 EST ---
Not a sponsor, just a quick look and few hints:
------
> Release:        1%{?dist}%{?extra_release}
should be just 
> Release:        1%{?dist}
------

%clean sections and rm -rf $RPM_BUILD_ROOT at the beginning of %install is no
longer needed. (unless you plan to get this to EL-5)
------

Shouldn't this be %doc as well?
%{_datadir}/snmp/mibs/LIBVIRT-MIB.txt

------
I am guessing this will be automatically added by rpm when building package so
no need for it:
Requires:       net-snmp

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.