[Bug 670377] Review Request: perl-File-Finder - Nice wrapper for File::Find ala find(1)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670377

Petr Pisar <ppisar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Petr Pisar <ppisar at redhat.com> 2011-03-02 11:33:17 EST ---
Source file is original. Ok.
Summary verified from lib/File/Finder.pm. Ok.
Description verified from lib/File/Finder.pm. Ok.
License verified from lib/File/Finder.pm. Ok.
No XS or other C binding. noarch architecture is Ok.

TODO: BuildRequire perl(Exporter) (lib/File/Finder.pm:7) as it can dual-live in
the future (http://search.cpan.org/~ferreira/Exporter/).

All tests pass. Ok.

$ rpmlint perl-File-Finder.spec ../SRPMS/perl-File-Finder-0.53-2.fc14.src.rpm
../RPMS/noarch/perl-File-Finder-0.53-2.fc14.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-File-Finder-0.53-2.fc14.noarch.rpm
drwxr-xr-x    2 root    root                        0 bře  2 17:23
/usr/share/doc/perl-File-Finder-0.53
-rw-r--r--    1 root    root                     1076 dub  8  2005
/usr/share/doc/perl-File-Finder-0.53/Changes
-rw-r--r--    1 root    root                     1076 pro 17  2003
/usr/share/doc/perl-File-Finder-0.53/README
-rw-r--r--    1 root    root                      748 dub  8  2005
/usr/share/doc/perl-File-Finder-0.53/TODO
-rw-r--r--    1 root    root                     4783 bře  2 17:23
/usr/share/man/man3/File::Finder.3pm.gz
-rw-r--r--    1 root    root                     6393 bře  2 17:23
/usr/share/man/man3/File::Finder::Steps.3pm.gz
drwxr-xr-x    2 root    root                        0 bře  2 17:23
/usr/share/perl5/File
drwxr-xr-x    2 root    root                        0 bře  2 17:23
/usr/share/perl5/File/Finder
-rw-r--r--    1 root    root                    10859 dub  8  2005
/usr/share/perl5/File/Finder.pm
-rw-r--r--    1 root    root                    17757 dub  8  2005
/usr/share/perl5/File/Finder/Steps.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-File-Finder-0.53-2.fc14.noarch.rpm |
sort | uniq -c
      1 perl(base)  
      1 perl(Carp)  
      1 perl(:MODULE_COMPAT_5.12.3)  
      1 perl(strict)  
      1 perl(Text::Glob)  
      1 perl(warnings)  
      1 perl >= 0:5.006
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rpmlib(VersionedDependencies) <= 3.0.3-1
$ rpm -q --provides -p ../RPMS/noarch/perl-File-Finder-0.53-2.fc14.noarch.rpm |
sort | uniq -c
      1 perl(File::Finder::Steps) = 0.53
      1 perl(File::Finder) = 0.53
      1 perl-File-Finder = 0.53-2.fc14
Binary dependencies Ok.

$ resolvedeps-f16 ../RPMS/noarch/perl-File-Finder-0.53-2.fc14.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F16
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2878749). Ok.

Otherwise package is in line with Fedora and perl packaging guidelines.

Please consider fixing all `TODO' prefixed issues before pushing package into
repository.

Resolution: Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.