[Bug 681424] Review Request: perl-Net-SSH-Expect - SSH wrapper to execute remote commands

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681424

--- Comment #6 from Ralf Corsepius <rc040203 at freenet.de> 2011-03-03 05:47:38 EST ---
MUSTFIXES:

* Please remove this:

%clean
[ "%{buildroot}" != "/" ] && rm -rf %{buildroot}

It's superflous for a long time.


* What is this supposed to do:
%if 0%{?fedora} <= 14
%define pvendorlib %{perl_privlib}
%endif
%if 0%{?fedora} >= 15
%define pvendorlib %{perl_vendorlib}
%endif
%if 0%{?rhel} >= 5
%define pvendorlib %{perl_vendorlib}
%endif

This %pvendorlib does not appear to be used anywhere inside of your spec, nor
have I evers seen it in any perl*spec before?

* Please remove this:
%define _use_internal_dependency_generator 1


Pardon, could it be you haven't packaged perl-modules for Fedora, before?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.