[Bug 681424] Review Request: perl-Net-SSH-Expect - SSH wrapper to execute remote commands

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681424

--- Comment #9 from Carl Thompson <fedora at red-dragon.com> 2011-03-03 13:58:17 EST ---
Spec URL: http://red-dragon.com/perl-Net-SSH-Expect.spec
SRPM URL: http://red-dragon.com/perl-Net-SSH-Expect-1.09-4.fc13.src.rpm

I have removed 
[ "%{buildroot}" != "/" ]
as your correct and it is no longer needed.

I use a custom macro defined based on the fedora/rhel build because those
macros are only standard per distro.  Many of us packagers of perl modules
found out the hard way that these macros change with F15 when almost all of the
specs had to be updated so they would build on F15 due to the macro change.

I prefer to maintain a single spec for all distros instead of a seperate spec
for each distro so I use the if statements to define a custom macro based on
the distro of build.

As you can see from the macro section:
%if 0%{?fedora} <= 14
%define pvendorlib %{perl_privlib}
%endif
%if 0%{?fedora} >= 15
%define pvendorlib %{perl_vendorlib}
%endif
%if 0%{?rhel} >= 5
%define pvendorlib %{perl_vendorlib}
%endif
the macro from F13 and F14 is perl_privlib while on F15+ as well as rhel its
perl_vendorlib.  It gets even more convoluted when they are arch based
libraries instead of noarch.

I have removed the legacy internal_dependency_generator

I have added PERL5_CPANPLUS_IS_RUNNING=1 as a standard that I will do with all
my perl packages to prevent any current or new packages I build from pulling
directly from CPAN

I'm checking out cpanspec because I wasn't familiar with it and will most
likely use it on the next package I work on to ease the creation of a spec file
for perl modules.

This is my second perl module package for fedora/epel so all input to improve
my procedures is greatly appreciated.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.