[Bug 655582] Review Request: mod_cluster - Apache HTTPD based load balancer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=655582

--- Comment #2 from Patrick Monnerat <pm at datasphere.ch> 2011-03-04 09:48:57 EST ---
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2884588

Some "first sight" remarks:

_ No alpha allowed in version for "final" releases.
  You should use version "1.1.0" and adapt the source URL accordingly.
_ Summary should be reworked, at least in compliance with rpmlint output.
_ Last upstream version is now 1.1.1
_ There are some bundled software in the source tarball (httpd, apr, ssl, etc):
  although you explicitly avoid using them, I would advise to remove the
  corresponding subdirectories before configure:
find srclib -mindepth 1 -maxdepth 1 ! -name mod_cluster -print0|xargs -0 -r rm
-rf
  this will cause compilation failure whenever a bundled directory is used.
_ You do not use RPM_OPT_FLAGS as a base for the compilation flags.
_ There are compilation warnings that do indicate potential problems
  (format descriptor/value type mismatch). Consider writing a patch for those.
_ You should include the license file srclib/mod_cluster/lgpl.txt as %doc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.