[Bug 678955] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678955

--- Comment #6 from Jerry James <loganjerry at gmail.com> 2011-03-04 16:54:50 EST ---
MUST items:
- rpmlint output:
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewGenOcclusionQueriesNV
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewXGetFBConfigAttribSGIX
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewXQueryGLXPbufferSGIX
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewFramebufferTexture2DEXT
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewDepthBoundsEXT
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewDeleteOcclusionQueriesNV
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewGenFramebuffersEXT
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLEW_NV_occlusion_query
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLEW_ARB_depth_texture
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewDeleteFramebuffers
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewRenderbufferStorageEXT
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewGetQueryObjectuivARB
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewXChooseFBConfigSGIX
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLEW_ARB_framebuffer_object
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewEndOcclusionQueryNV
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewGenRenderbuffers
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLEW_ARB_texture_env_dot3
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLEW_ATI_texture_float
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLEW_ARB_occlusion_query
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLEW_NV_float_buffer
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLEW_NV_texture_rectangle
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLXEW_SGIX_fbconfig
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewXDestroyGLXPbufferSGIX
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewBindFramebufferEXT
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewFramebufferRenderbufferEXT
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewXGetCurrentDisplay
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLXEW_SGIX_pbuffer
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewDeleteQueriesARB
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLXEW_NV_float_buffer
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewFramebufferRenderbuffer
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewBindRenderbuffer
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewEndQueryARB
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewGenRenderbuffersEXT
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewBeginOcclusionQueryNV
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLEW_EXT_packed_depth_stencil
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewGetOcclusionQueryuivNV
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewDeleteRenderbuffersEXT
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewXCreateGLXPbufferSGIX
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewRenderbufferStorage
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLEW_EXT_depth_bounds_test
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewDeleteFramebuffersEXT
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewCheckFramebufferStatusEXT
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewBeginQueryARB
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewGenQueriesARB
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewXCreateContextWithConfigSGIX
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewDeleteRenderbuffers
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewBindFramebuffer
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewGenFramebuffers
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewBindRenderbufferEXT
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__GLEW_EXT_framebuffer_object
opencsg.x86_64: W: undefined-non-weak-symbol /usr/lib64/libopencsg.so.1.3.1
__glewCheckFramebufferStatus
opencsg.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libopencsg.so.1.3.1 /usr/lib64/libGLU.so.1
opencsg.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libopencsg.so.1.3.1 /usr/lib64/libQtGui.so.4
opencsg.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libopencsg.so.1.3.1 /usr/lib64/libQtCore.so.4
opencsg.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libopencsg.so.1.3.1 /lib64/libm.so.6
opencsg-devel.x86_64: W: no-documentation
3 packages and 1 specfiles checked; 0 errors, 56 warnings.

This means that you need to change the link command for libopencsg.so so that
-lglew IS included, and -lGLU, -lQtGui, -lQtCore, and -lm are NOT included.
- package name: OK
- spec file name: OK
- packaging guidelines:
  Why are you passing -j1 to make?  If parallel make does not work (see
https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make), then please
include a comment stating so.
- license: OK
- license field: the license file lists an explicit exception to GPLv2, so the
license field should read "GPLv2 with exceptions".
- license file in %doc: no.  You must add license.txt to %doc.
- spec file in American English: OK
- spec file legible: OK
- source file matches upstream: OK, both have md5sum
6d2f91e72ebc0af55ea2a606059b1a79
- package builds: OK, checked on Fedora 14 x86_64
- appropriate use of ExcludeArch: N/A
- all build requirements in BuildRequires: OK
- locale handling: N/A
- ldconfig in %post and %postun: OK
- no copies of system libraries: OK
- relocatable package: N/A
- package owns all dirs it creates: N/A
- no duplicates in %files: OK
- proper permissions on files: OK
- consistent use of macros: OK, although I personally detest the %{__mkdir},
%{__mv}, and %{__rm} macros :-)
- code or permissible content: OK
- large documentation in -doc: N/A
- no runtime dependencies in %doc: OK
- header files in -devel: OK
- static libraries in -static: N/A
- .so files in -devel: OK
- -devel requires main package: OK, although you should consider using %{?_isa}
for multilib safety, like so:
Requires: %{name}%{?_isa} = %{version}-%{release}
- No libtool archives: OK
- desktop file for GUI applications: N/A
- do not own already-owned files/dirs: OK
- filenames are valid UTF-8: OK

SHOULD items:
- query upstream to include license text: N/A
- description and summary translations: N/A
- package builds in mock: OK
- package builds on all supported arches: did not check
- package functions as described: reviewer has no easy way to check
- sane scriptlets: OK
- subpackages depend on main package: OK
- pkgconfig files: N/A
- file dependencies: N/A
- man pages: N/A

Note that the BuildRoot tag and the %clean section in the spec file are
unnecessary on currently supported versions of Fedora.  Also, the HTML files
you put in %doc refer to files in the img directory; please add img to %doc. 
There may be value in including (parts of) the example directory in %doc as
well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.