[Bug 682414] Review Request: reptyr - Attach a running process to a new terminal

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682414

Sergio Belkin <sebelk at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sebelk at gmail.com

--- Comment #1 from Sergio Belkin <sebelk at gmail.com> 2011-03-06 00:53:02 EST ---
Hi Ville,

Some quick notes:

-rpmlint output:

reptyr.src: I: checking
reptyr.src: I: checking-url http://github.com/nelhage/reptyr (timeout 10
seconds)
reptyr.src: E: unknown-key (MD5
The package was signed, but with an unknown key. See the rpm --import option
for more information.

reptyr.src: W: invalid-url Source0: nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

1 packages and 0 specfiles checked; 1 errors, 1 warnings.

*** You should not sign the package, let Fedora Project do it :)

- **** Are you sure that you need:
 - BuildRoot
 - rm -rf $RPM_BUILD_ROOT in %install section
 - %clean section

Take a look at http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

Hope that helps

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.