[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682545

Pavel Zhukov <pavel at zhukoff.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pavel at zhukoff.net

--- Comment #1 from Pavel Zhukov <pavel at zhukoff.net> 2011-03-06 12:18:51 EST ---
Only few comments:

You're using RPM_BUILD_ROOT (variable style) and ?_smp_mflags (macro style) 
Mixing the two styles, while valid, is bad from a QA and usability point of
view, and should not be done in Fedora packages.
http://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

License is GPLv3+ 



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.