[Bug 682414] Review Request: reptyr - Attach a running process to a new terminal

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682414

--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi> 2011-03-07 02:51:24 EST ---
rpmlint output:
reptyr.src: W: invalid-url Source0: nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

NEEDSWORK:
* Replace
 Source0:        nelhage-reptyr-reptyr-%{version}-0-g%{gitrev}.tar.gz
with the correct address
 Source0:       
https://download.github.com/nelhage-reptyr-reptyr-%{version}-0-g%{gitrev}.tar.gz


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK

MUST: The package must be named according to the Package Naming Guidelines.
NEEDSWORK
- You're not using a stable release, so you need to conform to

http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Non-Numeric_Version_in_Release

MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
OK
- License is MIT Modern style with sublicense

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. NEEDSWORK
- Add address as stated above.
- Source matches upstream
f529080ca426371745ab909e84da05ce  nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz
f529080ca426371745ab909e84da05ce 
../SOURCES/nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz

MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A

MUST: Optflags are used and time stamps preserved. ~OK
- To preserve time stamps in install, you should add a '-p' flag to the install
command.
- However, the time stamp of the original files seems to be the time of the VCS
checkout, so this is not necessary.

MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
SHOULD: %{?dist} tag is used in release. OK

SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. NEEDSWORK
- No license included.

SHOULD: The package builds in mock. OK
EPEL: Clean section exists. OK
EPEL: Buildroot cleaned before install. OK
EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.