[Bug 682414] Review Request: reptyr - Attach a running process to a new terminal

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682414

--- Comment #5 from Ville Skyttä <ville.skytta at iki.fi> 2011-03-07 13:46:07 EST ---
(In reply to comment #3)
> NEEDSWORK:
> * Replace
>  Source0:        nelhage-reptyr-reptyr-%{version}-0-g%{gitrev}.tar.gz
> with the correct address
>  Source0:       
> https://download.github.com/nelhage-reptyr-reptyr-%{version}-0-g%{gitrev}.tar.gz

Not done; that URL results in 404 Not Found for me in wget, curl, and Firefox. 

$ wget https://download.github.com/nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz
--2011-03-07 20:30:24-- 
https://download.github.com/nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz
Resolving download.github.com... 207.97.227.240
Connecting to download.github.com|207.97.227.240|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2011-03-07 20:30:25 ERROR 404: Not Found.

When someone has downloaded the tarball once (e.g. from the links in their web
interface), it seems that github caches it for some time making it appear that
the URL works, but then it disappears again later as witnessed above.  I don't
know of a way to link to their tarballs that would actually work with rpm and
be stable.  If you do, let me know.

I *guess* something like
https://github.com/nelhage/reptyr/tarball/%{name}-%{version}/nelhage-reptyr-reptyr-%{version}-0-g%{gitrev}.tar.gz
would work but there's no way I can be sure right now due to the caching
behavior described above (it works for me ATM, but then again I guess the URL
you suggested worked for you too when you tried it).


> MUST: The package must be named according to the Package Naming Guidelines.
> NEEDSWORK
> - You're not using a stable release, so you need to conform to
> 
> http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Non-Numeric_Version_in_Release

But this is the 0.2 release, not a non-released snapshot.  It's what you get
from downloading https://github.com/nelhage/reptyr/tarball/reptyr-0.2 . 
github's tarball names are just ugly, if you know how to get prettier ones, let
me know.


> SHOULD: If the package does not include license text(s) as separate files from
> upstream, the packager should query upstream to include it. NEEDSWORK
> - No license included.

Hm?  COPYING is included in the upstream tarball and shipped in the built
binary package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.