[Bug 682488] Review Request: drupal6-filefield - Defines a file field type

Tue Mar 8 06:36:59 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=682488

Tim Lauridsen <tla at rasmil.dk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Tim Lauridsen <tla at rasmil.dk> 2011-03-08 01:36:48 EST ---

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

[x] : MUST - Package is licensed with an open-source compatible license and
meets other legal requirements as defined in the legal section of Packaging
Guidelines.
[x] : MUST - Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[-] : MUST - %build honors applicable compiler flags or justifies otherwise.
[-] : MUST - All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x] : MUST - Package contains no bundled libraries.
[x] : MUST - Changelog in prescribed format.
[x] : MUST - Sources contain only permissible code or content.
[-] : MUST - %config files are marked noreplace or the reason is justified.
[x] : MUST - Each %files section contains %defattr
[x] : MUST - Macros in Summary, %description expandable at SRPM build time.
[-] : MUST - Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application.
[x] : MUST - Package requires other packages for directories it uses.
[x] : MUST - Package uses nothing in %doc for runtime.
[x] : MUST - Package is not known to require ExcludeArch.
[x] : MUST - Permissions on files are set properly.
[x] : MUST - Package does not contain duplicates in %files.
[-] : MUST - Fully versioned dependency in subpackages, if present.
[-] : MUST - Header files in -devel subpackage, if present.
[x] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
[-] : MUST - ldconfig called in %post and %postun if required.
[-] : MUST - Large documentation files are in a -doc subpackage, if required.
[x] : MUST - Package does not contain any libtool archives (.la)
[x] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x] : MUST - License field in the package spec file matches the actual license.
[-] : MUST - License file installed when any subpackage combination is
installed.
[-] : MUST - The spec file handles locales properly.
[x] : MUST - Package consistently uses macros. instead of hard-coded directory
names.
[x] : MUST - Package use %makeinstall only when make install DESTDIR=...
doesn't work.
[x] : MUST - Package meets the Packaging Guidelines.
[x] : MUST - Package is named according to the Package Naming Guidelines.
[-] : MUST - No %config files under /usr.
[x] : MUST - Package does not genrate any conflict.
[x] : MUST - Package does not contains kernel modules.
[x] : MUST - Package contains no static executables.
[x] : MUST - Package obeys FHS, except libexecdir and /usr/target.
[x] : MUST - Package must own all directories that it creates.
[x] : MUST - Package does not own files or directories owned by other packages.
[x] : MUST - Package installs properly.
[x] : MUST - Rpath absent or only used for internal libs.
[x] : MUST - Package is not relocatable.
[x] : MUST - Requires correct, justified where necessary.
[!] : MUST - Rpmlint output is silent.

        rpmlint drupal6-filefield-6.x.3.9-1.fc16.src.rpm

================================================================================
        drupal6-filefield.src: W: spelling-error %description -l en_US podcasts
-> podcast, pod casts, pod-casts
        1 packages and 0 specfiles checked; 0 errors, 1 warnings.

================================================================================

        rpmlint drupal6-filefield-6.x.3.9-1.fc16.noarch.rpm

================================================================================
        drupal6-filefield.noarch: W: spelling-error %description -l en_US
podcasts -> podcast, pod casts, pod-casts
        1 packages and 0 specfiles checked; 0 errors, 1 warnings.

================================================================================

[-] : MUST - Development .so files in -devel subpackage, if present.
[x] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
        MD5SUM this package     : 43aff980408beff7d8f5554282aad15b
        MD5SUM upstream package : 43aff980408beff7d8f5554282aad15b
[x] : MUST - Spec file is legible and written in American English.
[x] : MUST - Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-] : MUST - Static libraries in -static subpackage, if present.
[x] : MUST - Package contains a SysV-style init script if in need of one.
[x] : MUST - File names are valid UTF-8.
[-] : MUST - Useful -debuginfo package or justification otherwise.
[x] : SHOULD - Reviewer should test that the package builds in mock.
[-] : SHOULD - If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[x] : SHOULD - Dist tag is present.
[x] : SHOULD - No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x] : SHOULD - Final provides and requires are sane (rpm -q --provides and rpm
-q --requires).
[x] : SHOULD - Package functions as described.
[x] : SHOULD - Latest version is packaged.
[x] : SHOULD - Package does not include license text files separate from
upstream.
[-] : SHOULD - Man pages included for all executables.
[-] : SHOULD - Uses parallel make.
[-] : SHOULD - Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-] : SHOULD - The placement of pkgconfig(.pc) files are correct.
[x] : SHOULD - Scriptlets must be sane, if used.

[x] : SHOULD - SourceX is a working URL.
[!] : SHOULD - Description and summary sections in the package spec file
contains translations for supported Non-English languages, if available.
[?] : SHOULD - Package should compile and build into binary rpms on all
supported architectures.
[-] : SHOULD - %check is present and all tests pass.
[x] : SHOULD - Packages should try to preserve timestamps of original installed
files.
[x] : SHOULD - Spec use %global instead of %define.

Issues:
[!] : SHOULD - SourceX / PatchY prefixed with %{name}.
        Source0: http://ftp.drupal.org/files/projects/filefield-6.x-3.9.tar.gz
(filefield-6.x-3.9.tar.gz)

        should be 
        Source0:
http://ftp.drupal.org/files/projects/%{modname}-%{version}.tar.gz 
        I make it easier to bump the version
        Not a deal breaker.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.