[Bug 680205] Review Request: allegro5 - Allegro 5 is a game programming library.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680205

--- Comment #8 from Brandon McCaig <bamccaig at gmail.com> 2011-03-08 12:42:48 EST ---
Thanks. :) I think I have those addressed now. I had also noticed the DUMB
errors, but since I had installed all dumb packages I wasn't sure what to do.
:-X Glad you knew. :)

- Copied %defattr line beneath every %files line.

- Moved /.so$/ symlinks to devel packages.

- Moved %doc to top of main %files and added suggested files.

- Replaced Source0 URI with corrected URI.

- Added/removed suggested BuildRequires. I didn't have libXpm-devel installed
until my RPM failed to build with the new BuildRequires, though I was still
able to build before. Was it just excluding features automatically or
something?

- Added %{_includedir}/allegro5 and %exclude lines instead of %dir.

- Added n-v-r devel dependency to subpackage devels.

- Empty %doc removed.

- Used globs to simplify %files section. In addition to al_*.3* manpages, there
are also ALLEGRO_*.3* manpages. Can a glob like that be used for those too or
is it necessary to name them each explicitly? An example of such a file is
"%{_mandir}/man3/ALLEGRO_AUDIO_DEPTH.3.gz". At the very least I have
substituted /.gz$/ with *.

- The top of allegro5.cfg says that in UNIX it can be located at
/etc/allegro5rc so I've added %install commands to move it there with some
guidance from #fedora-devel. We'll see if I did it properly with the next
review. :-X

As for the libcurl-devel dependency, I borrowed that from one of the upstream
developers' Debian-based build tutorial:

http://wiki.allegro.cc/index.php?title=Install_Allegro5_From_SVN/Linux/Debian

I asked #allegro on freenode today and one of the developers told me that one
of the example programs can be made to use libcurl. So it's probably not
necessary right now. That made me think that maybe I should create a subpackage
for the example programs, but without the source code to examine their only
real use is testing that Allegro is installed and working. I guess I could
always create the subpackage for the binaries and users interested in the
source of the examples could fetch it separately... What do you think?

Some of my previous changes were made at home and apparently I forgot to push
them to my GitHub repository so I'll wait until I merge those before publishing
a new revision. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.