[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681558

--- Comment #3 from Tomas Mraz <tmraz at redhat.com> 2011-03-09 06:14:24 EST ---
The libvirt tarball from the .src.rpm is different from the one at the URL.
Please correct that.

If you update the .src.rpm and spec, please always bump the Release and add
Changelog entry.

I noted that the license is GPLv3 - only - is that intentional? The source
files do not contain any copyright comment - it is not required however it is
recommended that they contain it (at least the non-autogenerated ones). There
is the COPYING file that contains GPLv3 (which by itself allows the code to be
licensed under the later future GPL licenses). However README states that the
license is GPLv3 which limits it.

Why is the LIBVIRT-MIB.txt both in %doc and in the snmp/mibs data dir? I do not
think it should be %doc - it is not in the net-snmp-libs package which contains
most of the mib files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.