[Bug 682905] Review Request: lio-utils - Utilities for Generic Target Infrastructure

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682905

--- Comment #5 from Andy Grover <agrover at redhat.com> 2011-03-09 13:08:55 EST ---
(In reply to comment #3)
> Some comments:
> 
>  a) no url tag, where is this project living?
>  b) you might want to add the sha1 8ad98e3 to the tarball name?
>  c) -n %{name}-%{version} in %setup is the default and can be dropped 
>    (however, consider b))

I decided to keep the tarball name, since future releases should have proper
tarballs.

>  d) mixing of $RPM_BUILD_ROOT and %{buildroot}, pick one.
>  e) use macros for /etc, /sbin and /etc/init.d/
>  f) target is a very generic name, possible problem

True.. it's what upstream is using, so I'm hesitant to diverge.

>  g) change %defattr(-,root,root) ->  %defattr(-,root,root,-)
>  h) the package seems to be free for docs and with no url tag, the user
>     will have a hard time be able to use this utility.

Yeah, I'll be working with upstream to author some manpages.

>  i) Release:  1, please add disttag here.

All the rest are done. Revised versions:

http://fedorapeople.org/~grover/lio-utils.spec(2)
http://fedorapeople.org/~grover/srpms/lio-utils-3.2-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.