[Bug 681558] Review Request: libvirt-snmp - SNMP support for libvirt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=681558

--- Comment #5 from Tomas Mraz <tmraz at redhat.com> 2011-03-10 10:19:33 EST ---
(In reply to comment #4)
> Updated.
> 
> Spec URL:
> http://www.libvirt.org/git/?p=libvirt-snmp.git;a=blob;f=libvirt-snmp.spec.in;hb=HEAD
> 
> SRPM URL:
> ftp://libvirt.org/libvirt/snmp/libvirt-snmp-0.0.1-2.fc14.src.rpm
> 
> new tarball:
> ftp://libvirt.org/libvirt/snmp/libvirt-snmp-0.0.1-2.tar.gz

This does not make much sense - the tarball should stay the same if you're just
changing the .spec file and not the source files. I know that you have the
.spec.in in the upstream git repository however the Fedora spec should track
the upstream spec only on rebases of the sources. So I recommend to use the
0.0.x versioning for the upstream tarball and have the spec file changes
tracked only in the upstream git. Not to change the tarball with all the spec
changes.

> LIBVIRT-MIB.txt is also in %doc, because it is part of documentation to allow
> users see what information they can gather/set.

This does not make much sense to me. The file is in the filesystem at one place
and there is no reason to duplicate it as %doc somewhere else. Perhaps at most
duplicate it as a symlink in the doc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.