[Bug 682414] Review Request: reptyr - Attach a running process to a new terminal

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682414

--- Comment #6 from Jussi Lehtola <jussi.lehtola at iki.fi> 2011-03-10 12:02:24 EST ---
(In reply to comment #5)
> (In reply to comment #3)
> > NEEDSWORK:
> > * Replace
> >  Source0:        nelhage-reptyr-reptyr-%{version}-0-g%{gitrev}.tar.gz
> > with the correct address
> >  Source0:       
> > https://download.github.com/nelhage-reptyr-reptyr-%{version}-0-g%{gitrev}.tar.gz
> 
> Not done; that URL results in 404 Not Found for me in wget, curl, and Firefox. 

Umm.. did you expand the macros? I tested it with
 $ spectool -g reptyr.spec
and it worked.

It's not working anymore, since the tarball doesn't exist anymore. The current
snapshot from the master branch is 
 nelhage-reptyr-reptyr-0.2-2-g919fff7.tar.gz
In the 0.2 tag it is
 nelhage-reptyr-reptyr-0.2-2-g919fff7.tar.gz

Note that this is a review blocker.

> When someone has downloaded the tarball once (e.g. from the links in their web
> interface), it seems that github caches it for some time making it appear that
> the URL works, but then it disappears again later as witnessed above.  I don't
> know of a way to link to their tarballs that would actually work with rpm and
> be stable.  If you do, let me know.
> 
> I *guess* something like
> https://github.com/nelhage/reptyr/tarball/%{name}-%{version}/nelhage-reptyr-reptyr-%{version}-0-g%{gitrev}.tar.gz
> would work but there's no way I can be sure right now due to the caching
> behavior described above (it works for me ATM, but then again I guess the URL
> you suggested worked for you too when you tried it).

I was able to get the same tarball as you before, so this is not true.

It's not a problem if the source URL doesn't work anymore after the revision in
question has vanished from upstream.

However, that way it's just way easier for the maintainer to plug in the
correct snapshot ID in the spec file and run
 $ spectool -g package.spec

> But this is the 0.2 release, not a non-released snapshot.  It's what you get
> from downloading https://github.com/nelhage/reptyr/tarball/reptyr-0.2 . 
> github's tarball names are just ugly, if you know how to get prettier ones, let
> me know.

Whenever you use snapshots from VCS, you MUST insert the snapshot revision in
the Release field.

> > SHOULD: If the package does not include license text(s) as separate files from
> > upstream, the packager should query upstream to include it. NEEDSWORK
> > - No license included.
> 
> Hm?  COPYING is included in the upstream tarball and shipped in the built
> binary package.

Whoops, my mistake.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.