[Bug 683071] Review Request: php-libvirt - PHP bindings for libvirt virtualization toolkit

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 10 19:02:41 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683071

--- Comment #10 from Tomas Mraz <tmraz at redhat.com> 2011-03-10 14:02:40 EST ---
The php-libvirt-0.4.1.tar.gz in the src.rpm and the
http://libvirt.org/sources/php/php-libvirt-0.4.1.tar.gz tarballs still differ.

The upstream project is still named libvirt-php - perhaps the tarball should
stay with the name libvirt-php and just name the src.rpm package php-libvirt?

Also I see the license was changed to LGPLv2+ - at least according to the
LICENSE and README files - have you got an approval from all of the
contributors to the project to change the license? You cannot change the
license from GPLv2 to LGPLv2+ without it as the GPLv2 is stronger - more
restrictive license.

Also the LICENSE and probably also the README file should stay in the base
package as %doc and should not go into the doc subpackage.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list