[Bug 652543] Review Request: erlang-riak_client - Erlang client for Riak

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652543

Michel Alexandre Salim <michel+fdr at sylvestre.me> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #6 from Michel Alexandre Salim <michel+fdr at sylvestre.me> 2011-03-11 17:17:13 EST ---
Everything looks good -- APPROVED

* DONE Review [100%]
  - [X] Names [2/2]
    - [X] Package name
   matches Erlang packaging convention
    - [X] Spec name
  - [X] Package version [2/2]
 http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning
      - [X] Version number
     http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag
      - [X] Release tag
     http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag
    
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
  - [X] Meets
[[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
  - [X] Source files match upstream
 67d75b7147181a5a1e31547cd017ffd5 
basho-riak-erlang-client-riakc-1.1.0-0-gd2297bf.tar.gz
 67d75b7147181a5a1e31547cd017ffd5 
/home/michel/rpmbuild/SOURCES/basho-riak-erlang-client-riakc-1.1.0-0-gd2297bf.tar.gz
  - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No
bundled libraries]]
  - [X] License [4/4]
    - [X] License is Fedora-approved
    - [X] No licensing conflict
    - [X] License field accurate
    - [X] License included iff packaged by upstream
  - [X] rpmlint [2/2]
    - [X] on src.rpm
   erlang-riak_client.src: W: invalid-url Source0:
basho-riak-erlang-client-riakc-1.1.0-0-gd2297bf.tar.gz
   1 packages and 0 specfiles checked; 0 errors, 1 warnings.

   harmless; spectool does not know how to handle download redirect's effect on
   filenames

    - [X] on x86_64.rpm
   erlang-riak_client.x86_64: E: explicit-lib-dependency erlang-stdlib
   erlang-riak_client.x86_64: E: no-binary
   erlang-riak_client.x86_64: W: only-non-binary-in-usr-lib
   1 packages and 0 specfiles checked; 2 errors, 1 warnings.

   Unavoidable since there's no automatic dependency script for Erlang

  - [X] Language & locale [2/2]
    - [X] Spec in US English
    - [X] Spec legible
  - [X] Build [3/3]
    - [X] Koji results
   http://koji.fedoraproject.org/koji/taskinfo?taskID=2905392
    - [X] BRs complete
    - [X] Directory ownership
  - [X] Spec inspection [8/8]
    - [X] No duplicate files
    - [X] File permissions
    - [X] Filenames must be UTF-8
    - [X] no BuildRoot
([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if
targeting EPEL5]])
    - [X] Has %clean section
   note: can be dropped unless you're targeting EPEL as well
    - [X] %buildroot cleaned on %install
    - [X] Macro usage consistent
    - [X] Documentation [1/1]
      - [X] %doc files are non-essential

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.