[Bug 682754] Review Request: perl-MooseX-GlobRef - Store a Moose object in glob reference
bugzilla at redhat.com
bugzilla at redhat.com
Sat Mar 12 09:35:13 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=682754
--- Comment #2 from Iain Arnell <iarnell at gmail.com> 2011-03-12 04:35:12 EST ---
Obsoletes/Provides are not good. As rpmlint has spotted, this package
will obsolete itself. Since nothing explicitly requires
perl-MooseX-GlobRef-Object (it appears only to be a build-req of
perl-MooseX-NonMoose), you should drop the explicit provides.
Other than that, the package appears to be okay.
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2906317
Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.
Source tarballs match upstream (sha1sum):
4ea6261f3cec3bcdbe5f4b4b9702a015f0e76e29 MooseX-GlobRef-0.0701.tar.gz
4ea6261f3cec3bcdbe5f4b4b9702a015f0e76e29 MooseX-GlobRef-0.0701.tar.gz.srpm
Final provides / requires are sane:
======> perl-MooseX-GlobRef-0.0701-1.fc16.noarch.rpm <======
====> rpmlint
perl-MooseX-GlobRef.noarch: W: self-obsoletion perl-MooseX-GlobRef-Object <=
0.0701-2 obsoletes perl-MooseX-GlobRef-Object = 0.0701
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
perl(MooseX::GlobRef) = 0.0701
perl-MooseX-GlobRef = 0.0701-1.fc16
perl-MooseX-GlobRef-Object = 0.0701
perl(MooseX::GlobRef::Object) = 0.0701
perl(MooseX::GlobRef::Role::Meta::Instance) = 0.0701
perl(MooseX::GlobRef::Role::Object) = 0.0701
====> requires
perl >= 0:5.006
perl(:MODULE_COMPAT_5.12.3)
perl(Moose)
perl(Moose) >= 0.94
perl(Moose::Exporter)
perl(Moose::Role)
perl(Moose::Util::MetaRole)
perl(MooseX::GlobRef)
perl(MooseX::GlobRef::Role::Meta::Instance)
perl(MooseX::GlobRef::Role::Object)
perl(Scalar::Util)
perl(strict)
perl(warnings)
====> obsoletes
perl-MooseX-GlobRef-Object <= 0.0701-2
====> conflicts
====> mock install
INFO: mock.py version 1.1.9 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.9
INFO: Mock Version: 1.1.9
State Changed: lock buildroot
INFO: installing package(s): perl-MooseX-GlobRef-0.0701-1.fc16.noarch.rpm
INFO:
================================================================================
Package Arch Version Repository Size
================================================================================
Installing:
perl-MooseX-GlobRef noarch 0.0701-1.fc16
/perl-MooseX-GlobRef-0.0701-1.fc16.noarch
22 k
Installing for dependencies:
perl-Class-C3 noarch 0.22-6.fc15 fedora 27 k
perl-Class-MOP x86_64 1.12-2.fc15 fedora 170 k
perl-Data-OptList noarch 0.106-4.fc15 fedora 12 k
perl-Devel-GlobalDestruction x86_64 0.02-12.fc15 fedora 13 k
perl-List-MoreUtils x86_64 0.30-2.fc15 fedora 60 k
perl-MRO-Compat noarch 0.11-6.fc15 fedora 17 k
perl-Moose x86_64 1.24-1.fc16 fedora 663 k
perl-Package-DeprecationManager noarch 0.10-3.fc15 fedora 16 k
perl-Package-Stash noarch 0.26-1.fc16 fedora 28 k
perl-Package-Stash-XS x86_64 0.22-1.fc16 fedora 28 k
perl-Params-Util x86_64 1.03-2.fc15 fedora 37 k
perl-Sub-Exporter noarch 0.982-7.fc15 fedora 66 k
perl-Sub-Install noarch 0.925-8.fc15 fedora 20 k
perl-Sub-Name x86_64 0.05-3.fc15 fedora 14 k
perl-Task-Weaken noarch 1.02-10.fc15 fedora 17 k
perl-Try-Tiny noarch 0.07-2.fc15 fedora 18 k
Transaction Summary
================================================================================
Install 17 Package(s)
Total size: 1.2 M
Installed size: 2.4 M
Installed:
perl-MooseX-GlobRef.noarch 0:0.0701-1.fc16
Dependency Installed:
perl-Class-C3.noarch 0:0.22-6.fc15
perl-Class-MOP.x86_64 0:1.12-2.fc15
perl-Data-OptList.noarch 0:0.106-4.fc15
perl-Devel-GlobalDestruction.x86_64 0:0.02-12.fc15
perl-List-MoreUtils.x86_64 0:0.30-2.fc15
perl-MRO-Compat.noarch 0:0.11-6.fc15
perl-Moose.x86_64 0:1.24-1.fc16
perl-Package-DeprecationManager.noarch 0:0.10-3.fc15
perl-Package-Stash.noarch 0:0.26-1.fc16
perl-Package-Stash-XS.x86_64 0:0.22-1.fc16
perl-Params-Util.x86_64 0:1.03-2.fc15
perl-Sub-Exporter.noarch 0:0.982-7.fc15
perl-Sub-Install.noarch 0:0.925-8.fc15
perl-Sub-Name.x86_64 0:0.05-3.fc15
perl-Task-Weaken.noarch 0:1.02-10.fc15
perl-Try-Tiny.noarch 0:0.07-2.fc15
State Changed: unlock buildroot
======> perl-MooseX-GlobRef-0.0701-1.fc16.src.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
====> requires
perl(Module::Build)
perl(Moose) >= 0.94
perl(parent)
perl(Test::Assert)
perl(Test::Unit::Lite) >= 0.12
====> obsoletes
====> conflicts
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list