[Bug 678924] Review Request: perl-Math-Random-ISAAC-XS - C implementation of the ISAAC PRNG algorithm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678924

--- Comment #2 from Iain Arnell <iarnell at gmail.com> 2011-03-12 05:02:56 EST ---
You should BuildRequire: perl(Test::LeakTrace) to enable t/03memory.t
You should package Test::Valgrind and submit for review (not a blocker).
You need to strip the carriage returns from the example scripts.

rpmlint is confused by "MIT or GPL+ or Artistic" but the license is correct and
valid.



koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2906368

Spec looks sane, clean and consistent; license is correct (MIT or GPL+ or
Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
3a05d7b32556b9f140ad83621d04b4648fe2dff4 Math-Random-ISAAC-XS-1.004.tar.gz
3a05d7b32556b9f140ad83621d04b4648fe2dff4 Math-Random-ISAAC-XS-1.004.tar.gz.srpm

Final provides / requires are sane:

======> perl-Math-Random-ISAAC-XS-1.004-1.fc16.src.rpm <======
====> rpmlint
perl-Math-Random-ISAAC-XS.src: W: invalid-license Artistic
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
====> requires
perl(ExtUtils::CBuilder)  
perl(ExtUtils::ParseXS)  
perl(Math::Random::ISAAC)  
perl(Module::Build)  
perl(Test::More)  
perl(Test::NoWarnings)  
====> obsoletes
====> conflicts

======> perl-Math-Random-ISAAC-XS-1.004-1.fc16.x86_64.rpm <======
====> rpmlint
perl-Math-Random-ISAAC-XS.x86_64: W: invalid-license Artistic
perl-Math-Random-ISAAC-XS.x86_64: E: wrong-script-end-of-line-encoding
/usr/share/doc/perl-Math-Random-ISAAC-XS-1.004/examples/benchmark.pl
perl-Math-Random-ISAAC-XS.x86_64: E: wrong-script-end-of-line-encoding
/usr/share/doc/perl-Math-Random-ISAAC-XS-1.004/examples/distribution.pl
1 packages and 0 specfiles checked; 2 errors, 1 warnings.
====> provides
perl(Math::Random::ISAAC::XS) = 1.004
perl-Math-Random-ISAAC-XS = 1.004-1.fc16
perl-Math-Random-ISAAC-XS(x86-64) = 1.004-1.fc16
====> requires
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
perl(Math::Random::ISAAC)  
perl(:MODULE_COMPAT_5.12.3)  
perl(strict)  
perl(warnings)  
perl(XSLoader)  
rtld(GNU_HASH)  
====> obsoletes
====> conflicts

======> perl-Math-Random-ISAAC-XS-debuginfo-1.004-1.fc16.x86_64.rpm <======
====> rpmlint
perl-Math-Random-ISAAC-XS-debuginfo.x86_64: W: invalid-license Artistic
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
perl-Math-Random-ISAAC-XS-debuginfo = 1.004-1.fc16
perl-Math-Random-ISAAC-XS-debuginfo(x86-64) = 1.004-1.fc16
====> requires
====> obsoletes
====> conflicts


====> mock install
INFO: mock.py version 1.1.9 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.9
INFO: Mock Version: 1.1.9
State Changed: lock buildroot
INFO: installing package(s): perl-Math-Random-ISAAC-XS-1.004-1.fc16.x86_64.rpm
perl-Math-Random-ISAAC-XS-debuginfo-1.004-1.fc16.x86_64.rpm
INFO: 
================================================================================
 Package                             Arch   Version      Repository        Size
================================================================================
Installing:
 perl-Math-Random-ISAAC-XS           x86_64 1.004-1.fc16
/perl-Math-Random-ISAAC-XS-1.004-1.fc16.x86_64
                                                                           80 k
 perl-Math-Random-ISAAC-XS-debuginfo x86_64 1.004-1.fc16
/perl-Math-Random-ISAAC-XS-debuginfo-1.004-1.fc16.x86_64
                                                                           73 k
Installing for dependencies:
 perl-Math-Random-ISAAC              noarch 1.004-2.fc16 fedora            36 k

Transaction Summary
================================================================================
Install       3 Package(s)

Total size: 188 k
Installed size: 235 k

Installed:
  perl-Math-Random-ISAAC-XS.x86_64 0:1.004-1.fc16                               
  perl-Math-Random-ISAAC-XS-debuginfo.x86_64 0:1.004-1.fc16                     

Dependency Installed:
  perl-Math-Random-ISAAC.noarch 0:1.004-2.fc16                                  


State Changed: unlock buildroot

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.