[Bug 682963] Review Request: perl-JSON-Util - Easy and portable encode/decode of JSON

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682963

--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2011-03-12 05:14:56 EST ---
You should BuildRequire perl(Test::Distribution) to enable more tests, and it's
good to see that you've already submitted perl-Test-Fixme for review.

APPROVED.


koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2893159

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
79e3eeebf150cbad64249ba99646e11674b9edfd JSON-Util-0.05.tar.gz
79e3eeebf150cbad64249ba99646e11674b9edfd JSON-Util-0.05.tar.gz.srpm

Final provides / requires are sane:

======> perl-JSON-Util-0.05-1.fc16.noarch.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
perl(JSON::Util) = 0.05
perl-JSON-Util = 0.05-1.fc16
====> requires
perl >= 1:5.010
perl(Carp)  
perl(feature)  
perl(IO::Any)  
perl(JSON::XS)  
perl(:MODULE_COMPAT_5.12.3)  
perl(Scalar::Util)  
perl(strict)  
perl(warnings)  
====> obsoletes
====> conflicts

======> perl-JSON-Util-0.05-1.fc16.src.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
====> requires
perl(IO::Any)  
perl(JSON::XS)  
perl(Module::Build)  
perl(Test::Differences)  
perl(Test::Exception)  
perl(Test::More)  
====> obsoletes
====> conflicts


====> mock install
INFO: mock.py version 1.1.9 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.9
INFO: Mock Version: 1.1.9
State Changed: lock buildroot
INFO: installing package(s): perl-JSON-Util-0.05-1.fc16.noarch.rpm
INFO: 
================================================================================
 Package          Arch   Version       Repository                          Size
================================================================================
Installing:
 perl-JSON-Util   noarch 0.05-1.fc16   /perl-JSON-Util-0.05-1.fc16.noarch  10 k
Installing for dependencies:
 perl-IO-Any      noarch 0.04-2.fc16   fedora                              12 k
 perl-IO-String   noarch 1.08-12.fc15  fedora                              15 k
 perl-IO-stringy  noarch 2.110-15.fc15 fedora                              69 k
 perl-JSON-XS     x86_64 1:2.30-2.fc15 fedora                              94 k
 perl-common-sense
                  noarch 3.3-2.fc15    fedora                              23 k

Transaction Summary
================================================================================
Install       6 Package(s)

Total size: 223 k
Total download size: 12 k
Installed size: 451 k

Installed:
  perl-JSON-Util.noarch 0:0.05-1.fc16                                           

Dependency Installed:
  perl-IO-Any.noarch 0:0.04-2.fc16        perl-IO-String.noarch 0:1.08-12.fc15 
  perl-IO-stringy.noarch 0:2.110-15.fc15  perl-JSON-XS.x86_64 1:2.30-2.fc15    
  perl-common-sense.noarch 0:3.3-2.fc15  


State Changed: unlock buildroot

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.