[Bug 684398] Review Request: Webilder - Configurable and automatic desktop wallpaper changer

bugzilla at redhat.com bugzilla at redhat.com
Sat Mar 12 18:20:49 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684398

--- Comment #5 from Stjepan Gros <stjepan.gros at gmail.com> 2011-03-12 13:20:48 EST ---
I'm approved packager but this is my first python desktop package.

> what is /usr/lib/bonobo/servers/GNOME_WebilderApplet.server why it placed in
> /usr/lib? It's XML please correct setup-files

As far as I can see, those XML files really go into /usr/lib, the only problem
is that on 64-bit platform they should be in /usr/lib64 but I don't know enough
python setuptools to know where/how it is defined.

> Package have broken BuildRequires 
> 1) You MUST add python-setuptools to BuildRequires

Added.

> 2) I get this message
> error: Could not find module No module named gnomeapplet. Please fix it. I'm
> sure that you have to add gnome-python2-applet BR
> Koji 

Also added.

> 3) Possible others

Surrently I'm on slow/expensive link otherwise I would do mock build.

> Please add %{?dist} to Release.

Added.

> You package contains locales (it and fr) but you doen't add they to rpm.

I wrote in second comment that I have problem with locale files, again because
they are installed in "wrong" location/path. So, I'm aware that they are here,
and rpmlint complains about them, but I don't know what's best way to fix that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list