[Bug 678634] Review Request: Saaghar - A Cross-Platform Persian Poetry Software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678634

Raghu Udiyar <raghusiddarth at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |raghusiddarth at gmail.com

--- Comment #1 from Raghu Udiyar <raghusiddarth at gmail.com> 2011-03-13 16:21:16 EDT ---
Hello Hedayat,

Few things to note :

- Consider using lower case for the spec and package name :

http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Case_Sensitivity

- BuildRoot and %clean are not required any more :

http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

- Add some description for the patches - are they Fedora specific? Can the
patches be integrated into upstream? See :

http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

- Use desktop-file-validate :
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

- Looks like a typo in the release field :

Release:        1.1051%{?dist}

- You can omit the %dir in the files section :

%dir %{_datadir}/saaghar


HTH

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.