[Bug 684087] Review Request: perl-Catalyst-View-HTML-Template - HTML::Template View Class

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684087

Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de
               Flag|                            |fedora-review+

--- Comment #1 from Ralf Corsepius <rc040203 at freenet.de> 2011-03-14 02:47:01 EDT ---
This package looses a "requires:" when being built against Fedora < 15:

# rpm -q --requires -p
/var/lib/mock/fedora-rawhide-x86_64/result/perl-Catalyst-View-HTML-Template-0.03-1.fc16.noarch.rpm
| sort > requ.fc16

# rpm -q --requires -p
/var/lib/mock/fedora-14-x86_64/result/perl-Catalyst-View-HTML-Template-0.03-1.fc14.noarch.rpm
| sort > requ.fc14

# diff -u requ.fc14 requ.fc16
--- requ.fc14 2011-03-14 07:28:52.923752276 +0100
+++ requ.fc16 2011-03-14 07:29:07.337139204 +0100
@@ -1,4 +1,5 @@
 perl(base)  
+perl(Catalyst::View)  
 perl(HTML::Template)  
 perl(:MODULE_COMPAT_5.12.3)  
 perl(strict)  

Please add something similar to this to your spec:
%if 0%{?fedora} < 15
Requires: perl(Catalyst::View)
%endif

Besides this, this is a clean and simple package, sources match upstream:
63a0055097d640b6d5b345815a96502d  Catalyst-View-HTML-Template-0.03.tar.gz
installs cleanly, etc., etc.


I guess you are aware about
http://lists.fedoraproject.org/pipermail/perl-devel/2011-March/034369.html.

AFAIS, perl-Catalyst-Controller-FormBuilder has been added a filter to avoid
depending on perl(Catalyst::Helper::View::HTML::Template)

IMO, this filter actually is wrong and should be removed once this package has
entered Fedora.


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.