[Bug 684835] Review Request: deltacloud-core - Deltacloud REST API server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684835

--- Comment #3 from Vít Ondruch <vondruch at redhat.com> 2011-03-15 09:48:24 EDT ---
* Cleaning
  - "rm -rf %{buildroot}" at the top of %install and %clean sections
    is no longer needed:
    https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

* Duplicated BuildRequires
  - BuildRequires: rubygem(json) is duplicated

* Test suite
  - It is interesting is that following commands provides different output:
      1) testrb tests/*_test.rb tests/drivers/mock/*_test.rb
      2) testrb tests/drivers/mock/*_test.rb tests/*_test.rb
      3) rake test
    while they should be equivalent.

* Missing runtime Requires:

  [vondruch at dhcp-25-40 result]$ deltacloudd -i mock
  Starting Deltacloud API :: mock :: http://localhost:3001/api

  ERROR: no such file to load -- rack/accept

  - Please compare with the BuildRequires which are sufficient. There are very
    probably missing nokogiri, rake-accept and may be others.

* Deleting the %{_builddir}
  - It is bad practice to delete %{_builddir} in installation step. It is not
    harmful in this particular case, but once there would be binary extensions
    it may cause troubles. This is coming from Ruby guidelines:

"Finally at %install stage the whole tree under the directory created at %prep
stage should be copied (not moved) to under %{buildroot}%{gemdir}.

    When all tree under the directory created at %prep stage is moved to under
    %{buildroot}, find_debuginfo.sh will complain that the corresponding source
    files are missing."

* Garbage in support folder?
  - It seems that folder /usr/share/deltacloud-core/support contains some
    unnecessary stuff, potentially garbage? There is only "deltacloud-core"
    which is later moved into %{_initdir}, the rest should not be installed,
    nor it should be part of the gem IMO.

* Upstream
  - The upstream package is not available yet. Please synchronize the release
    with upstream.

* Documentation
  - COPYING file should be marked as %doc.
  - Rakefile should be moved into doc subpackage, since it is not required by
    runtime

* MUST: A package must own all directories that it creates.
  - Package does not own the %{app_root}/public directory (at least it stays on
    my system after uninstall).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.