[Bug 678678] Review Request: rubygem-vte - Ruby binding of vte

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678678

Vít Ondruch <vondruch at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #3 from Vít Ondruch <vondruch at redhat.com> 2011-03-16 11:14:52 EDT ---
* Installation original gem
  - This is apparently upstream bug, comparing the 'vte-0.90.8/ext/vte/depend'
    with the 'gtksourceview2-0.90.8/ext/gtksourceview2/depend', which I
reviewed
    for you previously. So I am wondering if this bug is reported upstream?
  - This gem repackaging stuff seems to me pretty ugly. I would suggest the
other
    way around, i.e. install the gem without the '--with-pkg-config-dir' which
is
    working just fine and later move the generated ruby-vte.pc into appropriate
    place. Or is there something I am missing?

* gtk2 dependency
  - Upstream specifies gtk2 >= 0.90.8 runtime dependency while you allow
    dependency on 0.90.7. I just want to ensure that this is intentional, 
    not by mistake.

* rpmlint output:
  - rubygem-vte.src: W: strange-permission vte-0.90.8.gem 0600L

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.