[Bug 677804] Review Request: drwright - Typing monitor to force typing breaks

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=677804

Jerry James <loganjerry at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #6 from Jerry James <loganjerry at gmail.com> 2011-03-16 18:02:12 EDT ---
(In reply to comment #5)
> Added: desktop-file-validate (was an oversight)
> Fixed the BRs (they were right initially, I updated to a git snapshot, and then
> I removed intltool and libSM-devel for some reason and kept libtool instead. 
> Odd)

That's what package review is for, eh? :-)

> I did not add the scriptlet requires per
> http://fedoraproject.org/wiki/Packaging:ScriptletSnippets

Oh, I see.  Hmmmm, shouldn't the templates on that page check whether the
binaries are available instead of just blindly running them, then?  Anyway,
that's out of the scope of this review.  All the MUST items are now covered, so
I approve this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.