[Bug 688157] Review Request: cpupowerutils - Tools to determine and set CPU power related settings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688157

--- Comment #2 from Petr Sabata <psabata at redhat.com> 2011-03-17 05:43:22 EDT ---
Marcela,

thank you for the review.

(In reply to comment #1)
> (...)
> - package MUST successfully compile and build
> http://koji.fedoraproject.org/koji/taskinfo?taskID=2919367
> - architecture listed in ExcludeArch MUST have a bug filed in bugzilla  OK
> - build dependencies must be listed in BuildRequires  ?

Fixed by re-including the old 'disable-gsic' patch.

> (...)
> - devel package usually require base package ?

Fixed.

> (...)
> In archive is directory cpupowerutils-cpupowerutils. Is it intentional?

This was a gitorious.org export. I repackaged the sources tarball to look sane,
dropping the %setup -n option.

> Patch0 should be sent to upstream or have at least bug in our bugzilla.

This was reported by EL6 QA -- language files should have the same creation
times on all architectures. Since Koji might build packages at different times,
it's not always the case. This patch forces a certain exact time for them.

Fixed spec and 0.2.p1 SRPM:
http://psabata.fedorapeople.org/packages/cpupowerutils/cpupowerutils.spec
http://psabata.fedorapeople.org/packages/cpupowerutils/cpupowerutils-009-0.2.p1.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.