[Bug 688408] Review Request: xfce4-cpufreq-plugin - CPU frequency scaling plugin for the Xfce4 panel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688408

Mario Blättermann <mariobl at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mariobl at gnome.org

--- Comment #1 from Mario Blättermann <mariobl at gnome.org> 2011-03-17 17:38:05 EDT ---
Some issues:

Because your package is using the folder

%{_datadir}/icons/hicolor/

you should add the following line:

Requires: hicolor-icon-theme

This installation (not runtime!) dependency won't picked up automatically.


Moreover, no group is defined. I would recommend »User Interface/Desktops«, as
usual for other Xfce plugins.

Please use macros consistently. Replace $RPM_BUILD_ROOT with %{buildroot}.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.