[Bug 676129] Review Request: qconf - Allows you to have a nice configure script for your qmake-based project

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676129

Michal Schmidt <mschmidt at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mschmidt at redhat.com

--- Comment #3 from Michal Schmidt <mschmidt at redhat.com> 2011-03-18 08:05:46 EDT ---
"GPL" is not an acceptable value of the "License" tag.
>From a quick look at the license header in qconf.cpp and the COPYING file I'd
guess the correct value is "GPLv2+ with exceptions". See
https://fedoraproject.org/wiki/Licensing

Can you use the "%configure" macro instead of passing arguments to ./configure
by yourself?

Please use parallel make whenever possible. See
https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

You do not need to clean the buildroot at the beginning of %install. On all
current Fedora releases it is cleaned automatically. Only if you want the spec
file to work on EPEL-5, you still need to clean it yourself.
See https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

You may want to drop the %clean section. Again, it is only needed in EPEL-5.
https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

Using macros for the standard utilities (as in "%{__rm}") is discouraged. See
https://fedoraproject.org/wiki/Packaging/Guidelines#Macros

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.