[Bug 688056] Review Request: sir - A simple application for resizing images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688056

Rahul Sundaram <metherid at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |metherid at gmail.com

--- Comment #1 from Rahul Sundaram <metherid at gmail.com> 2011-03-18 10:09:09 EDT ---

Use macros in source0

INSTALL shouldn't be packaged

License tag must be GPLv2+.  Don't just read the license.  Look at the source
file headers.  

rpmlint warnings to be fixed:

sir.spec:21: W: macro-in-comment %{name}  (rpmlint on spec file)

sir.x86_64: W: unstripped-binary-or-object /usr/bin/sir
sir.x86_64: E: zero-length /usr/share/doc/sir-2.1.1/TODO
sir.x86_64: W: no-manual-page-for-binary sir

"#remove binary
rm %{name}"

Why is this necessary?

"%{_datadir}/applications/*.desktop"

better not to use a catch all for a single desktop file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.