[Bug 688056] Review Request: sir - A simple application for resizing images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688056

--- Comment #2 from Praveen Kumar <kumarpraveen.nitdgp at gmail.com> 2011-03-18 12:51:33 EDT ---
(In reply to comment #1)
> Use macros in source0
> 
> INSTALL shouldn't be packaged
> 
> License tag must be GPLv2+.  Don't just read the license.  Look at the source
> file headers.  
Fixed 
> 
> rpmlint warnings to be fixed:
> 
> sir.spec:21: W: macro-in-comment %{name}  (rpmlint on spec file)
> 
> sir.x86_64: W: unstripped-binary-or-object /usr/bin/sir
Can't understand what's unstripped-binary-or-object mean, please explain.
> sir.x86_64: E: zero-length /usr/share/doc/sir-2.1.1/TODO
TODO is removed from doc section
> sir.x86_64: W: no-manual-page-for-binary sir
> 
> "#remove binary
> rm %{name}"
> 
> Why is this necessary?
Source already contain a binary, before build section we have to remove all
binary IIRC.
> 
> "%{_datadir}/applications/*.desktop"
> 
> better not to use a catch all for a single desktop file.
Fixed

Here is updated spec and srpm urls 
Spec URL: http://kumarpraveen.fedorapeople.org/sir/sir.spec
SRPM URL: http://kumarpraveen.fedorapeople.org/sir/sir-2.1.1-2.fc14.src.rpm

rpmlint Output :
$ rpmlint sir.spec 
sir.spec: W: invalid-url Source0:
http://sir.googlecode.com/files/sir_2.1.1.tar.gz HTTP Error 404: Not Found
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
(may be due to proxy its not able to resolve url)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.