[Bug 688056] Review Request: sir - A simple application for resizing images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688056

--- Comment #4 from Praveen Kumar <kumarpraveen.nitdgp at gmail.com> 2011-03-18 15:54:59 EDT ---
(In reply to comment #3)
> Debuginfo package is not being generated.  Confirm with mock and check your
> Makefile/configure scripts to see why.  
In my system debuginfo package is generated.
Please take a look
http://kumarpraveen.fedorapeople.org/sir/sir-debuginfo-2.1.1-2.fc14.i686.rpm

> Inform upstream of this.  Merely not including it %files would omit it out of
> the package.  
I informed to upstream for removing the binaries. 

> Also rpmlint should be run on spec file, srpm and binary rpm

$rpmlint sir.spec ../SRPMS/sir-2.1.1-2.fc14.src.rpm
../RPMS/i686/sir-2.1.1-2.fc14.i686.rpm 
sir.spec: W: invalid-url Source0:
http://sir.googlecode.com/files/sir_2.1.1.tar.gz HTTP Error 404: Not Found
sir.src: W: invalid-url Source0:
http://sir.googlecode.com/files/sir_2.1.1.tar.gz HTTP Error 404: Not Found
sir.i686: W: no-manual-page-for-binary sir
2 packages and 1 specfiles checked; 0 errors, 3 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.