[Bug 688056] Review Request: sir - A simple application for resizing images

bugzilla at redhat.com bugzilla at redhat.com
Sat Mar 19 06:32:29 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688056

--- Comment #9 from Arun SAG <sagarun at gmail.com> 2011-03-19 02:32:27 EDT ---
(In reply to comment #8)
> 
> This MakeFile is generated using qmake and when I am using "make install
> DESTDIR=/path/to/install" then it is not creating directories(bin,pixmaps,share
> ..etc) on given path, but a GNU Makefile do. If above files are important then
> i can add manually.

A quick look at the makefile shows that, it is using INSTALL_ROOT as prefix.
Remove everything in install section and try using the following lines

"make install INSTALL_ROOT=$RPM_BUILD_ROOT
desktop-file-install --dir=$RPM_BUILD_ROOT%{_datadir}/applications
%{name}.desktop 

I do not know whether these files are important for the application, the
application is working fine without them; But it desirable to include them as
the original make file is installing them.

sir_service.desktop seems to adding this application to "Open with" dialog box.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list