[Bug 687915] Review Request: plasmate - IDE for Plasmoid

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=687915

Golo Fuchert <packages at golotop.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |packages at golotop.de

--- Comment #1 from Golo Fuchert <packages at golotop.de> 2011-03-20 10:31:01 EDT ---
Three initial comments:
- I have not worked with KDE widgets, so there might be a thing called "ion", 
  but maybe you meant icon here? Of course I apologize if there is an object
  called ion, wouldn't be too strange when talking about plasma, either. ;-)
- You surely know that it's not the best practice to use patches without any 
  comment why it is necessary and if upstream is aware of it. Also, upstream is
  very often quite happy about the .desktop files.
- You _could_ (but don't have to) use macros in the URL and Source0 tag and in 
  the files section.

Otherwise the package looks very good and clean to me (must have a closer look
though).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.