[Bug 688659] Review Request: thunarx-python - Python bindings for the Thunar Extension Framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688659

Kevin Fenzi <kevin at scrye.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Kevin Fenzi <kevin at scrye.com> 2011-03-21 22:42:00 EDT ---
Thanks for the fixes! 

1. This still isn't quite right... this has the 'or any later version', so it
should be 'LGPLv2+' as the License tag. 

2, 3, 4, 5 all look good and fixed. 

6. rpmlint now says: 
thunarx-python.src: W: invalid-license LGPL
thunarx-python.x86_64: W: invalid-license LGPL
thunarx-python-debuginfo.x86_64: W: invalid-license LGPL

which should be fixed by the License change. ;) 

You forgot to change the Release at the top from 1 to 2. ;) 

Fix those two things and I think everything looks good. You can do those two
changes before importing the package. This package is APPROVED. I'll go ahead
and sponsor you and you can continue the process from:
https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner
once I've added you to the packager group.

Welcome to the fun!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.