[Bug 669146] Review Request: gnumed-server - medical practice management - server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=669146

--- Comment #10 from Ankur Sinha <sanjay.ankur at gmail.com> 2011-03-23 04:22:12 EDT ---
Some suggestions: (None of these are blockers! :) )

- Instead of moving the example conf file, why not just write up a
fedora.README file and add it to docs? That way, the example file stays, and a
user will have a concrete source of documentation on how to set the server up?

- You don't need to gzip the man pages. IIRC rpm does that automagically.

- Is there a reason you're using mv instead of a simple rename?

For example:


for script in `ls ./*.sh`;
   do mv $script `echo $script|sed 's/.sh//'`;
done

could simply be written as

$ rename ".sh" "" *.sh

- You need to add a comment describing the patch. The patch should also be
named as gnumed-server-%reason.patch. Again, not a blocker, but this is the
preferred method.


Thanks,
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.