[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=671862

--- Comment #10 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2011-03-25 06:34:35 EDT ---
Some initial notes

* The latest version is 0.2.4.1, please upgrade
* About lauchpad bug 738153, the fix seems
  http://bazaar.launchpad.net/~synapse-core/synapse-project/trunk/revision/408
  Please consider to apply the patch
* Please make it sure that your srpm builds with mockbuild.
  Your srpm does not build at least without the following BRs:
-----------------------------------------------------
BuildRequires: intltool
BuildRequires: vala
BuildRequires: gtk2-devel
BuildRequires: libgee-devel
BuildRequires: json-glib-devel
BuildRequires: libgtkhotkey-devel
BuildRequires: unique-devel
-----------------------------------------------------
  You may also want to add "BR: rest-devel"
  Also I recommend to write one (Build)Requires per line
* Please address what I commented on bug 674188, like
  - BuildRoot: line, %clean, "rm -rf" at the first line of %install,
    no longer needed
  - %?_isa specific dependency
  - "V=1" on make
  - "INSTALL='install -p'" on make install
  - "-p" option for keeping timestamp

Additional notes
* You don't need to install the same document files (in %doc)
  in both main and -devel subpackages
* "INSTALL" file is generally for people who want to compile / install
  packages by themselves and not needed for people trying to install
  them via rpm
* For installed desktop file, icons under %_datadir/icons, please
  refer to:
 
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage
  https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.