[Bug 691195] Review Request: wmnet - Network monitoring dockapp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691195

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #2 from Martin Gieseking <martin.gieseking at uos.de> 2011-03-27 11:58:49 EDT ---
(In reply to comment #1)
> I haven't applied the recommended "strip wmnet" call for the package build, and
> "make" is called with the optflags macro. How can I make rpmlint happy
> again...?

You must ensure that the %optflags are applied. The default CFLAGS defined in
the Makefile don't contain gcc switch -g so that no debug info is generated. 
Replace OPTS with CFLAGS to fix that. 

Some further notes:
- The upstream location seems to be http://www.katharineosborne.com/wmnet.
  They also provide the latest version even if it's not listed on the website:
  http://www.katharineosborne.com/wmnet/wmnet-1.06.tar.gz

- Since there's no hint about the GPL version in the sources, the license tag
  would be GPL. However, wmnet relies on getopt (LGPLv2+) linked to 
  the binary. Thus, the GPL license of wmnet must be at least version 2.
  You should get a confirmation from upstream (if still reachable) about that.

- I recommend to remove the bundled getopt sources and use Fedora's ones 
  instead. Just add "rm -f getopt*" to %prep.

- Either use %optflags and %buildroot or $RPM_OPT_FLAGS and $RPM_BUILD_ROOT.
  Don't mix them.

- add INSTALL="install -p" to the make statements in order to preserve the
  timestamps (especially those of the manpage).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.