[Bug 690728] Review Request: Nitrate - A test case management system written in Django

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=690728

Mario Blättermann <mariobl at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mariobl at gnome.org

--- Comment #1 from Mario Blättermann <mariobl at gnome.org> 2011-03-27 13:49:06 EDT ---
Some initial issues:

- Release: shouldn't be a number only, use 1%{?dist} instead.
- Source0 has to be a downloadable link, not a filename only.
- %{python_sitelib}/* means that your package owns the whole folder,
  it should mention at least the appropriate subfolders for your package files:
  %{python_sitelib}/tcms/*
  %{python_sitelib}/Nitrate-%{version}-py2.7.egg-info/*
- The %changelog section at the end of the spec is actually not to use for
  changes to the sources, it's for changes to the package itself. In my mind,
  you should drop it because it's not really useful here. The whole source
  changelog has to be included in the package itself.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2950863

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.