[Bug 627032] Review Request: w3c-linkchecker - W3C Link Checker

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627032

--- Comment #2 from elad <el.il at doom.co.il> 2011-03-28 03:13:27 EDT ---
This is an unofficial review. You'll need someone else to do the official
review for you.

+ = OK
- = NA
? = issue

+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
? Meets Packaging Guidelines.
+ License
+ License field in spec matches
? License file included in package
+ Spec in American English
+ Spec is legible.
- Sources match upstream md5sum: 
    Upstream does not provide md5 sum or any other hash for the tar.gz file.
Please report a bug in the upstream and ask them to add an md5sum.
- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package has a correct %clean section.
+ Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
- Doc subpackage needed/used.
- Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
- Package owns all the directories it creates.
? No rpmlint output.
Please fix the following errors:

w3c-linkchecker.src: W: spelling-error %description -l en_US dereferenceable ->
teleconference
w3c-linkchecker.src: E: unknown-key (MD5
w3c-linkchecker.src: W: invalid-url Source0:
http://www.cpan.org/authors/id/S/SC/SCOP/W3C-LinkChecker-4.6.tar.gz HTTP Error
404: Not Found
1 packages and 0 specfiles checked; 1 errors, 2 warnings.


+ final provides and requires are sane.

SHOULD Items:

- Should build in mock.
- Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
? Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

Issues:

1. Please ask upstream to include the license in the tarball.
2. Upstream does not provide md5 sum or any other hash for the tar.gz file.
Please report a bug in the upstream and ask them to add an md5sum.
3. rpmlint couldn't find the Source URL because it is no longer avilable in
upstream. Please update the package to the latest version.
4. Do not place files in /var/www. Please read:
https://fedoraproject.org/wiki/Packaging:Guidelines#Web_Applications

Warnings:
1. Clean section is not required for Fedora 13 or above.
2. I'm not sure about it, but I think the upstream URL should be
http://search.cpan.org/dist/W3C-LinkChecker/
   Read https://fedoraproject.org/wiki/Packaging:Perl#URL_tag for more info.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.