[Bug 678195] Review Request: perl-MooseX-OneArgNew - Teach ->new to accept single, non-hashref arguments

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 28 08:37:37 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678195

Marcela Mašláňová <mmaslano at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mmaslano at redhat.com
               Flag|                            |fedora-review+

--- Comment #1 from Marcela Mašláňová <mmaslano at redhat.com> 2011-03-28 04:37:36 EDT ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source 87675d2bb98525d787e7509e6d581f50 OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

http://koji.fedoraproject.org/koji/taskinfo?taskID=2953107
rpm -qp --provides ~/Downloads/perl-MooseX-OneArgNew-0.001-1.fc16.noarch.rpm 
perl(MooseX::OneArgNew) = 0.001
perl-MooseX-OneArgNew = 0.001-1.fc16
rpm -qp --requires ~/Downloads/perl-MooseX-OneArgNew-0.001-1.fc16.noarch.rpm 
perl(:MODULE_COMPAT_5.12.3)  
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
perl(Moose::Util::TypeConstraints)  
perl(MooseX::Role::Parameterized)  
perl(namespace::autoclean)  
rpmlib(PayloadIsXz) <= 5.2-1

ACCEPTED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list