[Bug 691226] Review Request: perl-HTML-Form - Class that represents an HTML form element

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691226

--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2011-03-28 23:39:38 EDT ---
There's a few requires that weren't automatically detected and need to be
manually declared in the spec:

perl(HTML::TokeParser)
perl(HTTP::Request) >= 6
perl(HTTP::Request::Common) >= 6

But otherwise, a nice clean package. APPROVED.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2950823

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
45fe6121ea15fbc3fad4ab6851d2dbf1c72971d1 HTML-Form-6.00.tar.gz
45fe6121ea15fbc3fad4ab6851d2dbf1c72971d1 HTML-Form-6.00.tar.gz.srpm

Final provides / requires are sane:

======> perl-HTML-Form-6.00-1.fc16.noarch.rpm <======
====> rpmlint
perl-HTML-Form.noarch: W: spelling-error %description -l en_US UserAgent ->
User Agent, User-agent, Superagency
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
perl(HTML::Form) = 6.00
perl-HTML-Form = 6.00-1.fc16
perl(HTML::Form::FileInput)  
perl(HTML::Form::IgnoreInput)  
perl(HTML::Form::ImageInput)  
perl(HTML::Form::Input)  
perl(HTML::Form::KeygenInput)  
perl(HTML::Form::ListInput)  
perl(HTML::Form::SubmitInput)  
perl(HTML::Form::TextInput)  
====> requires
perl(Carp)  
perl(Encode)  
perl(:MODULE_COMPAT_5.12.3)  
perl(strict)  
perl(URI)  
perl(vars)  
====> obsoletes
====> conflicts

======> perl-HTML-Form-6.00-1.fc16.src.rpm <======
====> rpmlint
perl-HTML-Form.src: W: spelling-error %description -l en_US UserAgent -> User
Agent, User-agent, Superagency
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
====> requires
perl(ExtUtils::MakeMaker)  
perl(HTML::TokeParser)  
perl(HTTP::Request) >= 6
perl(HTTP::Request::Common) >= 6
perl(Test::More)  
perl(URI)  
====> obsoletes
====> conflicts


====> mock install
INFO: mock.py version 1.1.9 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.9
INFO: Mock Version: 1.1.9
State Changed: lock buildroot
INFO: installing package(s): perl-HTML-Form-6.00-1.fc16.noarch.rpm
INFO: 
================================================================================
 Package         Arch    Version      Repository                           Size
================================================================================
Installing:
 perl-HTML-Form  noarch  6.00-1.fc16  /perl-HTML-Form-6.00-1.fc16.noarch   63 k
Installing for dependencies:
 perl-URI        noarch  1.58-1.fc16  fedora                              102 k

Transaction Summary
================================================================================
Install       2 Package(s)

Total size: 164 k
Installed size: 249 k

Installed:
  perl-HTML-Form.noarch 0:6.00-1.fc16                                           

Dependency Installed:
  perl-URI.noarch 0:1.58-1.fc16                                                 


State Changed: unlock buildroot

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.