[Bug 671862] Review Request: synapse - gnome-do alternative (no mono)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=671862

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?

--- Comment #15 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2011-03-29 14:41:05 EDT ---
For 0.2.4.1-2

* License tag
  - The license tag for this package should be "GPLv3+"

* %{?_isa} specific dependency
  - Packages between main pkg and subpkgs should be %?_isa specific.
    i.e. synapse-devel should have 
    "Requires: %{name}%{?_isa} = %{version}-%{release}"
    https://fedoraproject.org/wiki/Packaging/Guidelines#Requires

* BuildRoot line
  - is no longer needed

* Timestamps
  - Please add "-p" option to "install" (or "cp") commands when
    installing files to keep timestamps on installed files.
    https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

* %check
  - It seems that currently "make check" does nothing, so this can
    be removed.

* empty documents
  - Unless you have some reason, emtry document files are useless
    and should be removed.

> Ok. But, what if someone installs either of them? License and README should be
> in both, don't you think? Maybe the Changelog too?

- Installing -devel subpackage also installs main package because of
  packages deps. So including such document files in main package is
  sufficient.

> >* "INSTALL" file is generally for people who want to compile / install
> >  packages by themselves and not needed for people trying to install
> >  them via rpm
> 
> I agree... but, since it's part of the package, maybe it shouldn't be
> omitted... maybe somebody want's to verify/upgrade/rebuild the package?

- So as I said, we verify/upgrade/rebuild a package via rpm(build)
  and "INSTALL" file need not be installed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.