[Bug 688035] Review Request: perl-CHI - Unified cache handling interface

bugzilla at redhat.com bugzilla at redhat.com
Wed Mar 30 03:16:22 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688035

--- Comment #8 from Iain Arnell <iarnell at gmail.com> 2011-03-29 23:16:21 EDT ---
perl-CHI-Test sub-package is missing two dependencies that will need to be
explicitly declared: perl(Test::Deep) and perl(Test::Exception)

But other than that, no problems. APPROVED.


koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2959095

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
7bab997dce1e7666695724b2ed329b49b91ba148 CHI-0.44.tar.gz
7bab997dce1e7666695724b2ed329b49b91ba148 CHI-0.44.tar.gz.srpm

Final provides / requires are sane:

======> perl-CHI-0.44-2.fc16.noarch.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
perl(CHI) = 0.44
perl-CHI = 0.44-2.fc16
perl(CHI::CacheObject) = 0.44
perl(CHI::Constants) = 0.44
perl(CHI::Driver) = 0.44
perl(CHI::Driver::Base::CacheContainer) = 0.44
perl(CHI::Driver::CacheCache) = 0.44
perl(CHI::Driver::FastMmap) = 0.44
perl(CHI::Driver::File) = 0.44
perl(CHI::Driver::Memory) = 0.44
perl(CHI::Driver::Metacache) = 0.44
perl(CHI::Driver::Null) = 0.44
perl(CHI::Driver::RawMemory) = 0.44
perl(CHI::Driver::Role::HasSubcaches) = 0.44
perl(CHI::Driver::Role::IsSizeAware) = 0.44
perl(CHI::Driver::Role::IsSubcache) = 0.44
perl(CHI::Driver::Role::Universal) = 0.44
perl(CHI::Serializer::JSON) = 0.44
perl(CHI::Serializer::Storable) = 0.44
perl(CHI::Stats) = 0.44
perl(CHI::Types) = 0.44
perl(CHI::Util) = 0.44
====> requires
perl >= 0:5.006
perl(base)  
perl(Cache::Cache)  
perl(Cache::FastMmap)  
perl(Carp)  
perl(Carp::Assert) >= 0.20
perl(CHI::CacheObject)  
perl(CHI::Constants)  
perl(CHI::Driver::Metacache)  
perl(CHI::Driver::Role::HasSubcaches)  
perl(CHI::Driver::Role::IsSizeAware)  
perl(CHI::Driver::Role::IsSubcache)  
perl(CHI::Driver::Role::Universal)  
perl(CHI::Serializer::JSON)  
perl(CHI::Serializer::Storable)  
perl(CHI::Stats)  
perl(CHI::Types)  
perl(CHI::Util)  
perl(Class::MOP)  
perl(constant)  
perl(Cwd)  
perl(Data::Dumper)  
perl(Data::UUID)  
perl(Digest::JHash)  
perl(Digest::MD5)  
perl(Encode)  
perl(Exporter)  
perl(Fcntl)  
perl(File::Basename)  
perl(File::Find)  
perl(File::Path)  
perl(File::Spec::Functions)  
perl(Hash::MoreUtils)  
perl(JSON)  
perl(List::MoreUtils) >= 0.13
perl(Log::Any) >= 0.06
perl(:MODULE_COMPAT_5.12.3)  
perl(Moose) >= 0.66
perl(Moose::Role)  
perl(Moose::Util::TypeConstraints)  
perl(Scalar::Util)  
perl(Storable)  
perl(strict)  
perl(Time::Duration) >= 1.06
perl(Time::Duration::Parse) >= 0.03
perl(Try::Tiny)  
perl(warnings)  
====> obsoletes
====> conflicts

======> perl-CHI-0.44-2.fc16.src.rpm <======
====> rpmlint
perl-CHI.src:48: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 48)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
====> requires
perl(Cache::FastMmap)  
perl(Cache::FileCache)  
perl(Carp::Assert) >= 0.20
perl(Compress::Zlib)  
perl(Data::UUID)  
perl(Date::Parse)  
perl(Digest::JHash)  
perl(ExtUtils::MakeMaker)  
perl(File::Spec) >= 0.80
perl(Hash::MoreUtils)  
perl(JSON)  
perl(List::MoreUtils) >= 0.13
perl(Log::Any) >= 0.08
perl(Log::Any::Adapter::Dispatch) >= 0.05
perl(Module::Load::Conditional)  
perl(Module::Mask)  
perl(Moose) >= 0.66
perl(Storable)  
perl(Task::Weaken)  
perl(Test::Builder)  
perl(Test::Class)  
perl(Test::Deep)  
perl(Test::Exception)  
perl(Test::Log::Dispatch)  
perl(Test::More)  
perl(Test::Pod)  
perl(Test::Warn)  
perl(Time::Duration) >= 1.06
perl(Time::Duration::Parse) >= 0.03
perl(Try::Tiny) >= 0.05
====> obsoletes
====> conflicts

======> perl-CHI-Test-0.44-2.fc16.noarch.rpm <======
====> rpmlint
perl-CHI-Test.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
perl(CHI::t::Bugs) = 0.44
perl(CHI::t::Constants) = 0.44
perl(CHI::t::Driver) = 0.44
perl(CHI::t::Driver::CacheCache) = 0.44
perl(CHI::t::Driver::FastMmap) = 0.44
perl(CHI::t::Driver::File) = 0.44
perl(CHI::t::Driver::File::BadTempDriver) = 0.44
perl(CHI::t::Driver::File::DepthZero) = 0.44
perl(CHI::t::Driver::File::NoTempDriver) = 0.44
perl(CHI::t::Driver::Memory) = 0.44
perl(CHI::t::Driver::NonMoose) = 0.44
perl(CHI::t::Driver::RawMemory) = 0.44
perl(CHI::t::Driver::Subcache) = 0.44
perl(CHI::t::Driver::Subcache::l1_cache) = 0.44
perl(CHI::t::Driver::Subcache::mirror_cache) = 0.44
perl(CHI::Test) = 0.44
perl-CHI-Test = 0.44-2.fc16
perl(CHI::Test::Class) = 0.44
perl(CHI::Test::Driver::NonMoose) = 0.44
perl(CHI::Test::Driver::Readonly) = 0.44
perl(CHI::Test::Driver::Role::CheckKeyValidity) = 0.44
perl(CHI::Test::Driver::Writeonly) = 0.44
perl(CHI::Test::Util) = 0.44
perl(CHI::t::GetError) = 0.44
perl(CHI::t::Initialize) = 0.44
perl(CHI::t::Null) = 0.44
perl(CHI::t::RequiredModules) = 0.44
perl(CHI::t::Sanity) = 0.44
perl(CHI::t::SetError) = 0.44
perl(CHI::t::Subcache) = 0.44
perl(CHI::t::Subclass) = 0.44
perl(CHI::t::Subclass::Driver::HasUnsupported) = 0.44
perl(CHI::t::Util) = 0.44
====> requires
perl(base)  
perl(Carp)  
perl(CHI)  
perl-CHI = 0.44-2.fc16
perl(CHI::Constants)  
perl(CHI::Driver::Memory)  
perl(CHI::t::Driver)  
perl(CHI::t::Driver::File)  
perl(CHI::t::Driver::Memory)  
perl(CHI::t::Driver::Subcache)  
perl(CHI::Test)  
perl(CHI::Test::Class)  
perl(CHI::Test::Driver::Role::CheckKeyValidity)  
perl(CHI::Test::Util)  
perl(CHI::Util)  
perl(Class::MOP)  
perl(Date::Parse)  
perl(Encode)  
perl(Exporter)  
perl(File::Basename)  
perl(File::Path)  
perl(File::Spec::Functions)  
perl(File::Temp)  
perl(Getopt::Long)  
perl(List::MoreUtils) >= 0.13
perl(List::Util)  
perl(Log::Any::Test)  
perl(Moose) >= 0.66
perl(Moose::Role)  
perl(Scalar::Util)  
perl(Storable)  
perl(strict)  
perl(Test::Builder)  
perl(Test::Class)  
perl(Test::More)  
perl(Test::Warn)  
perl(warnings)  
====> obsoletes
====> conflicts


====> mock install
INFO: mock.py version 1.1.9 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.9
INFO: Mock Version: 1.1.9
State Changed: lock buildroot
INFO: installing package(s): perl-CHI-0.44-2.fc16.noarch.rpm
perl-CHI-Test-0.44-2.fc16.noarch.rpm
INFO: 
================================================================================
 Package                         Arch   Version           Repository       Size
================================================================================
Installing:
 perl-CHI                        noarch 0.44-2.fc16      
/perl-CHI-0.44-2.fc16.noarch
                                                                          263 k
 perl-CHI-Test                   noarch 0.44-2.fc16      
/perl-CHI-Test-0.44-2.fc16.noarch
                                                                           87 k
Installing for dependencies:
 perl-CPAN                       noarch 1.9402-156.fc16   fedora          246 k
 perl-Cache-Cache                noarch 1.06-6.fc15       fedora           90 k
 perl-Cache-FastMmap             x86_64 1.36-2.fc15       fedora           50 k
 perl-Carp-Assert                noarch 0.20-8.fc15       fedora           20 k
 perl-Class-C3                   noarch 0.23-1.fc16       fedora           26 k
 perl-Class-MOP                  x86_64 1.12-2.fc15       fedora          170 k
 perl-Data-OptList               noarch 0.106-4.fc15      fedora           12 k
 perl-Devel-GlobalDestruction    x86_64 0.02-12.fc15      fedora           13 k
 perl-Digest-JHash               x86_64 0.07-1.fc16       fedora           12 k
 perl-Digest-SHA                 x86_64 1:5.47-156.fc16   fedora           63 k
 perl-Digest-SHA1                x86_64 2.13-2.fc15       fedora           49 k
 perl-Error                      noarch 1:0.17016-5.fc15  fedora           30 k
 perl-Exporter-Lite              noarch 0.02-10.fc15      fedora           10 k
 perl-ExtUtils-MakeMaker         noarch 6.56-156.fc16     fedora          289 k
 perl-ExtUtils-ParseXS           noarch 1:2.2206-156.fc16 fedora           44 k
 perl-Hash-MoreUtils             noarch 0.02-1.fc16       fedora          9.8 k
 perl-IPC-ShareLite              x86_64 0.17-3.fc15       fedora           30 k
 perl-JSON                       noarch 2.51-1.fc16       fedora           92 k
 perl-List-MoreUtils             x86_64 0.30-2.fc15       fedora           60 k
 perl-Log-Any                    noarch 0.11-3.fc15       fedora           25 k
 perl-MRO-Compat                 noarch 0.11-6.fc15       fedora           17 k
 perl-Moose                      x86_64 1.24-1.fc16       fedora          663 k
 perl-Package-DeprecationManager noarch 0.10-3.fc15       fedora           16 k
 perl-Package-Stash              noarch 0.27-1.fc16       local            28 k
 perl-Package-Stash-XS           x86_64 0.22-1.fc16       fedora           28 k
 perl-Params-Util                x86_64 1.03-2.fc15       fedora           37 k
 perl-Sub-Exporter               noarch 0.982-7.fc15      fedora           66 k
 perl-Sub-Install                noarch 0.925-8.fc15      fedora           20 k
 perl-Sub-Name                   x86_64 0.05-3.fc15       fedora           14 k
 perl-Sub-Uplevel                noarch 1:0.22-4.fc15     fedora           22 k
 perl-Task-Weaken                noarch 1.02-10.fc15      fedora           17 k
 perl-Test-Class                 noarch 0.36-3.fc15       fedora           68 k
 perl-Test-Harness               noarch 3.17-156.fc16     fedora          239 k
 perl-Test-Simple                noarch 0.98-1.fc16       fedora          117 k
 perl-Test-Warn                  noarch 0.23-1.fc16       fedora           17 k
 perl-Time-Duration              noarch 1.06-10.fc15      fedora           16 k
 perl-Time-Duration-Parse        noarch 0.06-6.fc15       fedora          9.4 k
 perl-TimeDate                   noarch 1:1.20-4.fc15     fedora           42 k
 perl-Tree-DAG_Node              noarch 1.06-10.fc15      fedora           55 k
 perl-Try-Tiny                   noarch 0.09-1.fc16       fedora           17 k
 perl-devel                      x86_64 4:5.12.3-156.fc16 fedora          448 k
 python                          x86_64 2.7.1-6.fc15      fedora           73 k
 systemtap-sdt-devel             x86_64 1.4-5.fc16        fedora           41 k
 uuid                            x86_64 1.6.2-4.fc15      fedora           50 k
 uuid-perl                       x86_64 1.6.2-4.fc15      fedora           27 k

Transaction Summary
================================================================================
Install      47 Package(s)

Total size: 3.7 M
Installed size: 8.3 M

Installed:
  perl-CHI.noarch 0:0.44-2.fc16        perl-CHI-Test.noarch 0:0.44-2.fc16       

Dependency Installed:
  perl-CPAN.noarch 0:1.9402-156.fc16                                            
  perl-Cache-Cache.noarch 0:1.06-6.fc15                                         
  perl-Cache-FastMmap.x86_64 0:1.36-2.fc15                                      
  perl-Carp-Assert.noarch 0:0.20-8.fc15                                         
  perl-Class-C3.noarch 0:0.23-1.fc16                                            
  perl-Class-MOP.x86_64 0:1.12-2.fc15                                           
  perl-Data-OptList.noarch 0:0.106-4.fc15                                       
  perl-Devel-GlobalDestruction.x86_64 0:0.02-12.fc15                            
  perl-Digest-JHash.x86_64 0:0.07-1.fc16                                        
  perl-Digest-SHA.x86_64 1:5.47-156.fc16                                        
  perl-Digest-SHA1.x86_64 0:2.13-2.fc15                                         
  perl-Error.noarch 1:0.17016-5.fc15                                            
  perl-Exporter-Lite.noarch 0:0.02-10.fc15                                      
  perl-ExtUtils-MakeMaker.noarch 0:6.56-156.fc16                                
  perl-ExtUtils-ParseXS.noarch 1:2.2206-156.fc16                                
  perl-Hash-MoreUtils.noarch 0:0.02-1.fc16                                      
  perl-IPC-ShareLite.x86_64 0:0.17-3.fc15                                       
  perl-JSON.noarch 0:2.51-1.fc16                                                
  perl-List-MoreUtils.x86_64 0:0.30-2.fc15                                      
  perl-Log-Any.noarch 0:0.11-3.fc15                                             
  perl-MRO-Compat.noarch 0:0.11-6.fc15                                          
  perl-Moose.x86_64 0:1.24-1.fc16                                               
  perl-Package-DeprecationManager.noarch 0:0.10-3.fc15                          
  perl-Package-Stash.noarch 0:0.27-1.fc16                                       
  perl-Package-Stash-XS.x86_64 0:0.22-1.fc16                                    
  perl-Params-Util.x86_64 0:1.03-2.fc15                                         
  perl-Sub-Exporter.noarch 0:0.982-7.fc15                                       
  perl-Sub-Install.noarch 0:0.925-8.fc15                                        
  perl-Sub-Name.x86_64 0:0.05-3.fc15                                            
  perl-Sub-Uplevel.noarch 1:0.22-4.fc15                                         
  perl-Task-Weaken.noarch 0:1.02-10.fc15                                        
  perl-Test-Class.noarch 0:0.36-3.fc15                                          
  perl-Test-Harness.noarch 0:3.17-156.fc16                                      
  perl-Test-Simple.noarch 0:0.98-1.fc16                                         
  perl-Test-Warn.noarch 0:0.23-1.fc16                                           
  perl-Time-Duration.noarch 0:1.06-10.fc15                                      
  perl-Time-Duration-Parse.noarch 0:0.06-6.fc15                                 
  perl-TimeDate.noarch 1:1.20-4.fc15                                            
  perl-Tree-DAG_Node.noarch 0:1.06-10.fc15                                      
  perl-Try-Tiny.noarch 0:0.09-1.fc16                                            
  perl-devel.x86_64 4:5.12.3-156.fc16                                           
  python.x86_64 0:2.7.1-6.fc15                                                  
  systemtap-sdt-devel.x86_64 0:1.4-5.fc16                                       
  uuid.x86_64 0:1.6.2-4.fc15                                                    
  uuid-perl.x86_64 0:1.6.2-4.fc15                                               


State Changed: unlock buildroot

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list