[Bug 672561] Review Request: perl-Perl-Critic-Pulp - Some add-on perlcritic policies
bugzilla at redhat.com
bugzilla at redhat.com
Wed Mar 30 07:40:13 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672561
Marcela Mašláňová <mmaslano at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |mmaslano at redhat.com
Flag| |fedora-review+
--- Comment #2 from Marcela Mašláňová <mmaslano at redhat.com> 2011-03-30 03:40:11 EDT ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
http://koji.fedoraproject.org/koji/taskinfo?taskID=2959749
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
rpm -qp --provides ~/Downloads/perl-Perl-Critic-Pulp-46-1.fc16.noarch.rpm
perl(Perl::Critic::Policy::CodeLayout::RequireFinalSemicolon) = 46
perl(Perl::Critic::Policy::Compatibility::ConstantPragmaHash) = 46
perl(Perl::Critic::Policy::Compatibility::Gtk2Constants) = 46
perl(Perl::Critic::Policy::Compatibility::PerlMinimumVersionAndWhy) = 46
perl(Perl::Critic::Policy::Compatibility::PodMinimumVersion) = 46
perl(Perl::Critic::Policy::Compatibility::ProhibitUnixDevNull) = 46
perl(Perl::Critic::Policy::Documentation::ProhibitBadAproposMarkup) = 46
perl(Perl::Critic::Policy::Documentation::ProhibitBadAproposMarkup::Parser)
perl(Perl::Critic::Policy::Documentation::ProhibitVerbatimMarkup) = 46
perl(Perl::Critic::Policy::Documentation::ProhibitVerbatimMarkup::Parser)
perl(Perl::Critic::Policy::Documentation::RequireEndBeforeLastPod) = 46
perl(Perl::Critic::Policy::Miscellanea::TextDomainPlaceholders) = 46
perl(Perl::Critic::Policy::Miscellanea::TextDomainUnused) = 46
perl(Perl::Critic::Policy::Modules::ProhibitModuleShebang) = 46
perl(Perl::Critic::Policy::Modules::ProhibitPOSIXimport) = 46
perl(Perl::Critic::Policy::Modules::ProhibitUseQuotedVersion) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::ConstantBeforeLt) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::NotWithCompare) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitBarewordDoubleColon) =
46
perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitEmptyCommas) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitFiletest_f) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitNullStatements) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::ProhibitUnknownBackslash) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::RequireNumericVersion) = 46
perl(Perl::Critic::Policy::ValuesAndExpressions::UnexpandedSpecialLiteral) = 46
perl(Perl::Critic::Pulp) = 46
perl(Perl::Critic::Pulp::PodMinimumVersionViolation)
perl(Perl::Critic::Pulp::PodParser)
perl(Perl::Critic::Pulp::Utils) = 46
perl(Perl::MinimumVersion)
perl(Pod::MinimumVersion) = 46
perl(Pod::MinimumVersion::Parser)
perl(Pod::MinimumVersion::Report)
perl-Perl-Critic-Pulp = 46-1.fc16
rpm -qp --requires ~/Downloads/perl-Perl-Critic-Pulp-46-1.fc16.noarch.rpm |
sort
perl >= 0:5.005
perl >= 0:5.006
perl(base)
perl(constant)
perl(Exporter)
perl(IO::String) >= 1.02
perl(List::MoreUtils) >= 0.24
perl(List::Util)
perl(:MODULE_COMPAT_5.12.3)
perl(overload)
perl(Perl::Critic) >= 1.084
perl(Perl::Critic::Policy) >= 1.084
perl(Perl::Critic::Pulp)
perl(Perl::Critic::Pulp::PodParser)
perl(Perl::Critic::Pulp::Utils)
perl(Perl::Critic::Utils) >= 1.100
perl(Perl::Critic::Utils::PPI)
perl(Perl::Critic::Violation)
perl(Pod::MinimumVersion)
perl(Pod::Parser)
perl(POSIX)
perl(PPI) >= 1.208
perl(PPI::Document)
perl(Scalar::Util)
perl(strict)
perl(Test::More)
perl(vars)
perl(version)
perl(warnings)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
ACCEPT
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list