[Bug 691619] Review Request: openvas-manager - Open Vulnerability Assessment (OpenVAS) Manager (edit)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691619

--- Comment #2 from Michal Ambroz <rebus at seznam.cz> 2011-03-30 09:22:55 EDT ---
Hello Carl,
thank you for feedback. I address the issues and upload new package at the
evening.

>? MUST: The package MUST successfully compile and build into binary rpms on at
Sorry for that - I will review dev dependencies once again.

>- MUST: If the package is designed to be relocatable, the packager must state
MA: Packageis not designed as relocatable and doesn't contain Prefix


>? MUST: A package must own all directories that it creates. If it does not
I will add dir %{_datadir}/openvas. Expect modified version uploaded this
evening.
I will not change to openvas-%{version} as the directory is used by other
openvas
packages as well and there is not a stong link to the version


>- MUST: Header files must be in a -devel package.
there are no header files


>- MUST: Static libraries must be in a -static package.
there are no static libraries
main binary openvasmd is linked dynamically


>- MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
not applicable

>- MUST: In the vast majority of cases, devel packages must require the base
not applicable - this is not devel package

>- MUST: Packages must NOT contain any .la libtool archives, these must be
not applicable - doesn't contain .la archives

>- MUST: Packages containing GUI applications must include a %{name}.desktop
not applicable - doesn't contain GUI application

>? SHOULD: If the source package does not include license text(s) as a separate
Not applicable - the package does include license text

>- SHOULD: The description and summary sections in the package spec file should
>contain translations for supported Non-English languages, if available.
Not applicable - translation is not available now.

>- SHOULD: Usually, subpackages other than devel should require the base package
>using a fully versioned dependency.
Not applicable - this is standalone module of openvas and is not tightly
limited for usage of all packages of the same version. 
Version specific requirement for compiled library is computed automatically
during
build as recommended by the packagin guideline:
"Packages must not contain explicit Requires on libraries except when
absolutely necessary. "

>- SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
not applicable - .pc files not included in the binary package

>- SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
I will add as this dependency was not detected by RPM, it is within /usr/bin
and explicit linking whole library is prohibited by the packaging guideline
Requires:       /usr/bin/xsltproc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.