[Bug 653800] Review Request: lde - Linux disk editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=653800

--- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info> 2011-03-31 02:12:09 EDT ---
Mario, thank you for the support words.

(In reply to comment #4)
> - The tab indents in the header should be tweaked a bit, for better
> readability.
No. You just use another tab width :) Please see initial my comment.

> - Use macros wherever possible: Replace all occurences of the package name
>   with %{name}.
Good catch. Fixed.

> - Add a -p switch to the install calls to keep timestamps.
Fixed.

> - The file allfs.h has the executable bit set, please remove it (of course
>   the bit itself, not the file ;-)
And it fixed also.


http://hubbitus.info/rpm/Fedora13/lde/lde-2.6.1-4.fc13.src.rpm
http://hubbitus.info/rpm/Fedora13/lde/lde.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.