[Bug 692281] Review Request: hotot - Lightweight & open source micro blogging client

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 31 10:23:11 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=692281

--- Comment #2 from Martin Gieseking <martin.gieseking at uos.de> 2011-03-31 06:23:10 EDT ---
Hi Rahul,

here are some initial comments:

- The package currently fails building with mock/koji because of the following
  missing BRs: intltool desktop-file-utils:
  https://koji.fedoraproject.org/koji/taskinfo?taskID=2962943

- Some of the js files in data/js are published under different licenses:
  * jquery.js: GPLv2
  * js-oauth.js: LGPLv3 only
  * sha1.js: BSD
  This must be reflected in the License field.

- Since I can't find any system dependent files, you should create a noarch 
  package.

- Don't explicitly clean the buildroot in %install as all the other buildroot 
  stuff is omitted too.

- Add --skip-build to "python setup install".

- Please ask upstream to add file COPYING with the LGPLv3 license text. The 
  python source files should also get the proper copyright headers as 
  requested by the (L)GPL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list