[Bug 684407] Review Request: perl-Monotone-AutomateStdio - Perl interface to Monotone via automate stdio

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684407

Marcela Mašláňová <mmaslano at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mmaslano at redhat.com

--- Comment #1 from Marcela Mašláňová <mmaslano at redhat.com> 2011-03-31 08:23:22 EDT ---
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
 3f0984cb465867071042c156c2f5c316
- package MUST successfully compile and build OK
 http://koji.fedoraproject.org/koji/taskinfo?taskID=2963286
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -qp --provides
~/Downloads/perl-Monotone-AutomateStdio-0.12-1.fc16.noarch.rpm 
perl(Monotone::AutomateStdio) = 0.12
perl-Monotone-AutomateStdio = 0.12-1.fc16

rpm -qp -requires
~/Downloads/perl-Monotone-AutomateStdio-0.12-1.fc16.noarch.rpm  | sort
perl >= 0:5.008005
perl(base)  
perl(Carp)  
perl(constant)  
perl(Cwd)  
perl(Encode)  
perl(Exporter)  
perl(File::Basename)  
perl(File::Spec)  
perl(IO::File)  
perl(IO::Handle)  
perl(IO::Poll)  
perl(IPC::Open3)  
perl(:MODULE_COMPAT_5.12.3)  
perl(POSIX)  
perl(Socket)  
perl(strict)  
perl(Symbol)  
perl(warnings)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

I have few comments on packaging. Shouldn't be mtn-tester also installed or run
as test?
Also upstream created strange pod file. Usually are pods created from pm files,
but that's not blocker.
NOT APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.